[Bug 692045] Port uvch264src to gstreamer 1.0

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=692045
  GStreamer | gst-plugins-bad | git

--- Comment #5 from Youness Alaoui <youness.alaoui at collabora.co.uk> 2013-01-24 02:40:55 UTC ---
Thanks Sjoerd and great job! :)
Couple of comments :
- I noticed a bug in the code, the 'nv12' pad has format=NV21 instead of NV12
(same on 0.10 branch)
- The VF_CAPS also had image/jpeg which I don't think are in
GST_VIDEO_FORMATS_ALL (so VID_CAPS also will be missing it)
- In gst_uvc_h264_src_fixate_caps, why did you remove the gst_caps_unref(tcaps)
?
- Same comment as Olivier about the gst_pad_fixate_caps
- I didn't look at the changed in the mjpeg_demux_chain cause it looks scary :)
- The custom_upstream "renegotiate" event handling should be removed and
replaced with handling the reconfigure event (or is that automatic?).

- In tests/examples/uvch264/window.glade, you forgot to change (fourcc) into
(string) for the caps.
- In
http://cgit.collabora.com/git/user/sjoerd/gst-plugins-bad.git/commit/?h=uvch264&id=d9c64a61634070d50314bf61c6018c965ea97f0b
you changed the section name but didn't change it in the docs/ file so it gets
picked up by gtk-doc.

That's about it from my side, but this is my first 1.0 code that I've looked at
so I might not be as qualified.

There is also a couple of bugfixes I've done recently on the 0.10 branch :
http://cgit.collabora.com/git/user/kakaroto/gst-plugins-bad.git/log/?h=0.10
You can ignore the PropertyProbe patch (until we have an equivalent for 1.0),
but there were a couple of bugs in transform_caps and handling of the caps ref
that might need porting to the 1.0 code.

Thanks!

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.