[Bug 692471] Issues with Ogg tag setting

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=692471
  GStreamer | gst-plugins-base | 1.x

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEEDINFO

--- Comment #2 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2013-01-25 00:21:35 UTC ---
> The first is TAG_APPLICATION_NAME, the second is TAG_LANGUAGE_CODE, and finally
> the last one is TAG_ENCODER.

An application should not set TAG_ENCODER.

> None of the 3 are successfully set in the output file,

Worksforme:

gst-launch-1.0 -q audiotestsrc num-buffers=10 ! taginject
tags='language-code=fr,application-name=Transmageddon,encoder=lame' ! vorbisenc
! fakesink dump=true | head -n 11

(not so much with theoraenc, but arguably that doesn't make much sense anyway)


> however the encoders seems to set their own value for TAG_ENCODER.

Which is the correct thing to do.

> There are some Tag specification here for Ogg-Vorbis - 
> http://www.xiph.org/vorbis/doc/v-comment.html 
> Doesn't mention something like TAG_APPLICATION_NAME or TAG_LANGUAGE_CODE, but I
> think we could add it ourselves.

Those two are already mapped, so I don't know what the problem is.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.