[Bug 664274] [API] codecparsers: add gst_mpeg_video_parse_slice() and gst_mpeg_video_parse_sequence_scalable_extension()

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=664274
  GStreamer | gst-plugins-bad | git

--- Comment #6 from Gwenole Beauchesne <gb.devel at gmail.com> 2013-01-25 14:38:26 UTC ---
(In reply to comment #5)
> (In reply to comment #3)
> > Adding it here is fine, thanks!
> 
> Done..
> What do you think about the gst_mpeg_video_parse_slice() API ?

I prefer the following data structure:

struct _GstMpegVideoSliceHdr {
    guint16 slice_horizontal_position;
    guint16 slice_vertical_position;
    guint8 quantiser_scale_code;
    guint8 intra_slice;

    /* Size of the slice() header in bits */
    guint header_size;
};

i.e. the macroblock_address needs to be correctly calculated, otherwise it's
useless for gst-vaapi purposes. Please have a look at the current
gstvaapidecoder_mpeg2.c:parse_slice() for a more correct implementation.

My copy of the MPEG-2 standard does not mention the picture_id, but if you see
a need for it, just add it then. :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.