[Bug 687182] playbin: autoplugging s/w and h/w accelerated deinterlacers
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Fri Jul 5 02:55:35 PDT 2013
https://bugzilla.gnome.org/show_bug.cgi?id=687182
GStreamer | gst-plugins-base | git
--- Comment #18 from sreerenj <bsreerenj at gmail.com> 2013-07-05 08:26:47 UTC ---
(In reply to comment #17)
> Review of attachment 248387 [details]:
>
>
> Shouldn't there be something to enable/disable the different postproc
> functions, i.e. enable/disable a denoise filter?
Do you meant to add properties for that?
Yup we need this feature anyways. Because, for eg: vaapipostproc can do many
vpp functions in a single pass. Something to enable/disable the filter would be
a nice feature.
> Why is this a property but HW acceleration is a vfunc?
Adding more properties to the interface will force the elements to add a
compatible property and the gst-inspect will display all those unnecessary (in
usual case) properties. In my thinking vpp-type was the main feature which
should be displaying by the gst-inspect. Actually I was thinking about the
vpp_methods also :) ..But as long as we have only vpp-type and
has_hw_acceleration, I have no objection to add it as a property.
Do you think it better to keep both of them as properties?
> ::: gst-libs/gst/video/videopostproc.h
> @@ +59,3 @@
> + GST_VIDEO_POSTPROC_DENOISE = (1 << 2),
> + GST_VIDEO_POSTPROC_SCALE = (1 << 3),
> + GST_VIDEO_POSTPROC_COLORSPACE = (1 << 4),
>
> This would probably not be just about colorspace conversion but also
> subsampling conversion, component order conversion, plane layout conversion,
> etc... like what videoconvert does?
So do we need to split each of them ? Then we need to answer Gwenole's question
:) "only add maximum of 32 vpp features" .
Otherwise just keep it as a simple GST_VIDEO_POSTPROC_COVERT. ?
note: Personally I prefer GstVideoPostProc instead of GstVideoPostProcessor.
But no objection to change it :)
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list