[Bug 702722] opencv: add GrabCut segmentation element
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Thu Jul 11 03:29:45 PDT 2013
https://bugzilla.gnome.org/show_bug.cgi?id=702722
GStreamer | gst-plugins-bad | 1.x
Sebastian Dröge <slomo> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #248843|none |needs-work
status| |
--- Comment #9 from Sebastian Dröge <slomo at circular-chaos.org> 2013-07-11 10:29:39 UTC ---
Review of attachment 248843:
--> (https://bugzilla.gnome.org/review?bug=702722&attachment=248843)
::: ext/opencv/gstfacedetect.c
@@ +681,3 @@
+ ev = gst_event_new_custom (GST_EVENT_CUSTOM_DOWNSTREAM, str);
+ gst_pad_push_event (GST_BASE_TRANSFORM_SRC_PAD
(GST_BASE_TRANSFORM_CAST
+ (filter)), ev);
I still believe this should be a GstMeta, attached to any buffer to which it is
relevant... potentially many per buffer if there are many faces :)
Why do you use doubles for the coordinates? Can they be fractional?
::: ext/opencv/gstgrabcut.cpp
@@ +182,3 @@
+IN CASE OF no alpha mask input (all 0's or all 1's), the 'face' \
+downstream event is used to create a bbox of PR_FG elements.\n\
+IF nothing is present, then nothing is done.", "Miguel Casas-Sanchez
<miguelecasassanchez at gmail.com>");
Please move this NOTE in the documentation still
@@ +364,3 @@
+ } else {
+
+ if ( (abs (gc->facepos.x) > 2) && (abs (gc->facepos.y) > 2)
I can understand the checks for the width/height of the facepos, but why must x
and y be > 2? Can't a face start at position (0,0)?
@@ +368,3 @@
+ GST_INFO ("running on bbox (%d,%d),(%d,%d)", gc->facepos.x,
gc->facepos.y,
+ gc->facepos.width, gc->facepos.height);
+ run_graphcut_iteration2 (&(gc->GC), gc->cvRGBin, gc->grabcut_mask,
Why is the element called grabcut but the algorithm graphcut? :)
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list