[Bug 704070] Add Region Of Interest (roi) meta
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Fri Jul 12 02:04:42 PDT 2013
https://bugzilla.gnome.org/show_bug.cgi?id=704070
GStreamer | gst-plugins-base | 1.x
Sebastian Dröge <slomo> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #248990|none |needs-work
status| |
--- Comment #1 from Sebastian Dröge <slomo at circular-chaos.org> 2013-07-12 09:04:37 UTC ---
Review of attachment 248990:
--> (https://bugzilla.gnome.org/review?bug=704070&attachment=248990)
::: gst-libs/gst/video/gstvideometa.c
@@ +536,3 @@
+{
+ static volatile GType type;
+ static const gchar *tags[] = { NULL };
Tags should probably be size and orientation as for the crop meta
@@ +564,3 @@
+ /* we always copy no matter what transform */
+ gst_buffer_add_video_region_of_interest_meta (transbuf, emeta->x, emeta->y,
emeta->w,
+ emeta->h);
And a transform function similar to the one of the crop meta too
::: gst-libs/gst/video/gstvideometa.h
@@ +255,3 @@
+ guint w;
+ guint h;
+ GQuark roi_type;
I guess the type should be in front of x
Also add some padding in the end
And some defines for pre-defined ROI types, like "face" :)
@@ +261,3 @@
+const GstMetaInfo *gst_video_region_of_interest_meta_get_info (void);
+
+#define gst_buffer_get_video_region_of_interest_meta(b)
((GstVideoRegionOfInterestMeta*)gst_buffer_get_meta((b),GST_VIDEO_REGION_OF_INTEREST_META_API_TYPE))
Maybe another macro to get the number of these metas and a specific one at a
index? Similar to GstVideoMeta
@@ +264,3 @@
+GstVideoRegionOfInterestMeta *gst_buffer_add_video_region_of_interest_meta
(GstBuffer * buffer,
+ guint x, guint y,
+ guint w, guint h);
Add a const gchar * roi_type parameter before x, y
And maybe a second function that takes a GQuark instead of the string
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list