[Bug 701353] rtp timestamps not correct when pausing/seeking

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Sun Jun 2 22:51:33 PDT 2013


https://bugzilla.gnome.org/show_bug.cgi?id=701353
  GStreamer | gst-plugins-base | 1.x

--- Comment #5 from Alexander Schrab <alexas at axis.com> 2013-06-03 05:51:29 UTC ---
(In reply to comment #3)
> Review of attachment 245731 [details]:
> 
> ::: gst-libs/gst/rtp/gstrtpbasepayload.c
> @@ +858,3 @@
> +      rtime += gst_element_get_base_time (GST_ELEMENT (payload));
> +      /* remove initial base time to get a time line starting from 0 */
> +      rtime -= payload->priv->initial_element_base;
> 
> What happnens if you preroll a buffer in PAUSED ? (where
> priv->initial_element_base == GST_CLOCK_TIME_NONE)
> 
> Might make sense to use "0" instead of as a "unset" value ?

You are correct, but we can't just use 0 since that would mean the first
package would have rtime same as clock time and the rest starting from 0. I
made a special case for this instead.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list