[Bug 696770] Memory leak when processing h.264 field pictures

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=696770
  GStreamer | gst-libav | 1.0.5

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #245998|none                        |reviewed
             status|                            |

--- Comment #8 from Sebastian Dröge <slomo at circular-chaos.org> 2013-06-04 15:27:07 UTC ---
Review of attachment 245998:
 --> (https://bugzilla.gnome.org/review?bug=696770&attachment=245998)

::: ext/libav/gstavviddec.c
@@ +1400,3 @@
+     ffmpeg is allocating the output buffer only for complete frames and not
+     for the individual fields. */
+  if (frame && !frame->output_buffer) {

I don't think this is correct. libav is not necessarily allocating an output
buffer for the current input frame immediately

Also does this mean that every GstVideoCodecFrame was a field here, not a
frame? In that case it would be something that the parser should've fixed,
GstVideoCodecFrame is supposed to be one complete frame with everything related
to it.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.