[Bug 686459] pulsesink: playbin uri=x.mp3 audio-sink='identity ! pulsesink' => not-negotiated flow error

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=686459
  GStreamer | gst-plugins-good | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |slomo at circular-chaos.org

--- Comment #11 from Sebastian Dröge <slomo at circular-chaos.org> 2013-06-06 12:47:14 UTC ---
(In reply to comment #9)

> > calls. Did you check that nothing called there can ever take the object lock
> > itself, and that there's no lock order inversion anywhere (you introduce
> > object_lock > mainloop lock here)
> 
> The only callers of GST_OBJECT_LOCK within that file are the ones I've added.
> All other locks on the object are taken at the GstAudioRingBuffer class level
> so the object lock -> mainloop lock order should always hold.

Note that various GStreamer functions can take the object lock too, like
gst_object_get_parent() ;)

But if you checked all this I'm fine with the patch

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.