[Bug 701706] gst-omx testegl.c example not compatible with gstreamer 1.x

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=701706
  GStreamer | gst-omx | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #246154|none                        |needs-work
             status|                            |

--- Comment #10 from Sebastian Dröge <slomo at circular-chaos.org> 2013-06-06 12:51:15 UTC ---
Review of attachment 246154:
 --> (https://bugzilla.gnome.org/review?bug=701706&attachment=246154)

This patch seems to include many unrelated changes to porting. Please clean
that up, afterwards I'll do a real review :)

::: examples/egl/testegl.c
@@ +137,3 @@
+  OMX_EGL_EXAMPLE_VIDEO_CUBE,
+  OMX_EGL_EXAMPLE_VIDEO_BACKGROUND,
+  /* .. */

Like this

@@ +250,3 @@
  *
  ***********************************************************/
+     static void init_ogl (APP_STATE_T * state)

Indention broken

@@ +1022,2 @@
+      g_mutex_lock (state->lock);
+      GST_DEBUG ("\neglglessink-allocate-eglimage %p ", query);

No \n here, and use GST_PTR_FORMAT to let it print the query

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.