[Bug 701385] Videomixer does incorrect timestamp calculations in certain cases, which leads to dropping buffers that should be kept.

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=701385
  GStreamer | gst-plugins-good | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #245770|none                        |reviewed
             status|                            |

--- Comment #5 from Sebastian Dröge <slomo at circular-chaos.org> 2013-06-07 11:52:44 UTC ---
Review of attachment 245770:
 --> (https://bugzilla.gnome.org/review?bug=701385&attachment=245770)

::: gst/videomixer/videomixer2.c
@@ +747,3 @@
+      /* We don't want the segment offset to influence our conversion to
running time */
+      start_time += segment->offset;
+      end_time += segment->offset;

Why not? That's exactly the point of the offset

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.