[Bug 701421] opencv: add foreground/background segmentation element

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=701421
  GStreamer | gst-plugins-bad | 1.x

Stefan Sauer (gstreamer, gtkdoc dev) <ensonic> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #246359|none                        |reviewed
             status|                            |

--- Comment #7 from Stefan Sauer (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2013-06-09 18:54:19 UTC ---
Review of attachment 246359:
 --> (https://bugzilla.gnome.org/review?bug=701421&attachment=246359)

::: ext/opencv/gstsegmentation.cpp
@@ +206,3 @@
+  g_object_class_install_property (gobject_class, PROP_DISPLAY,
+      g_param_spec_boolean ("display", "Display",
+          "Overwrite the output with foreground as white over background
black",

The description could be more detailed to tell when one would want to enable
this:
"Overwrite the output with foreground as white over background black to check
that ..."
The property name could probably be changed to "apply-mask" or "test-mode". I
also first though that "display" would be there to switch the effect to
pass-through mode.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.