[Bug 701915] New: [PATCH] wrappercamerabinsrc: Don't unset the video-source property on pipeline start

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=701915
  GStreamer | gst-plugins-bad | unspecified

           Summary: [PATCH] wrappercamerabinsrc: Don't unset the
                    video-source property on pipeline start
    Classification: Platform
           Product: GStreamer
           Version: unspecified
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: jwrdegoede at fedoraproject.org
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=246384)
 View: https://bugzilla.gnome.org/attachment.cgi?id=246384
 Review: https://bugzilla.gnome.org/review?bug=701915&attachment=246384

[PATCH] wrappercamerabinsrc: Don't unset the video-source property on pipeline
start

[PATCH] wrappercamerabinsrc: Don't unset the video-source property on pipeline
start

check_and_replace_src() was setting self->app_vid_src to NULL, which
means that an app setting the video-source property, and then starting,
stopping and re-starting the pipeline (ie to make changes to the
video-source-filter property) would after the restart no longer have
a video-source.

Also if the try_element check on app_vid_src in
gst_camerabin_setup_default_element() fails, then
gst_camerabin_setup_default_element() can still return a success status
and in that case app_vid_src would be set to NULL without its ref being
passed, thus leaking memory..

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.