[Bug 701915] [PATCH] wrappercamerabinsrc: Don't unset the video-source property on pipeline start

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=701915
  GStreamer | gst-plugins-bad | unspecified

--- Comment #3 from Sebastian Dröge <slomo at circular-chaos.org> 2013-06-10 13:01:43 UTC ---
Review of attachment 246384:
 --> (https://bugzilla.gnome.org/review?bug=701915&attachment=246384)

::: gst/camerabin2/gstwrappercamerabinsrc.c
@@ +480,3 @@
+    /* If we're using app_vid_src, take a ref to pass on to the bin */
+    if (self->src_vid_src == self->app_vid_src)
+      gst_object_ref (self->app_vid_src);

Erm, first review got lost somehow. I think
gst_camerabin_setup_default_element() should just return a new reference if it
uses the user element, that is more intuitive and causes consistent behaviour
of that function.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.