[Bug 701915] [PATCH] wrappercamerabinsrc: Don't unset the video-source property on pipeline start

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=701915
  GStreamer | gst-plugins-bad | unspecified

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |1.1.2
 Attachment #246403|none                        |committed
             status|                            |
             Status|RESOLVED                    |NEW
         Resolution|FIXED                       |
   Target Milestone|1.1.2                       |HEAD

--- Comment #5 from Sebastian Dröge <slomo at circular-chaos.org> 2013-06-10 14:17:16 UTC ---
commit 8dc7fae455266f8e93101fb83edcd9bf41e97544
Author: Hans de Goede <hdegoede at redhat.com>
Date:   Mon Jun 10 10:05:56 2013 +0200

    wrappercamerabinsrc: Don't unset the video-source property on pipeline
start

    check_and_replace_src() was setting self->app_vid_src to NULL, which
    means that an app setting the video-source property, and then starting,
    stopping and re-starting the pipeline (ie to make changes to the
    video-source-filter property) would after the restart no longer have
    a video-source.

    This patch fixes this by making gst_camerabin_setup_default_element return
a
    ref to the passed in user_element, rather then returning the user_element
as
    is, so that that ref can be passed on to the bin, and the app_vid_src ref
    stays valid.

    https://bugzilla.gnome.org/show_bug.cgi?id=701915

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.