[Bug 701404] dashdemux: should not buffer the entire Period

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon Jun 10 15:34:35 PDT 2013


https://bugzilla.gnome.org/show_bug.cgi?id=701404
  GStreamer | gst-plugins-bad | 1.x

Olivier Crete (Tester) <olivier.crete> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #245806|none                        |needs-work
             status|                            |

--- Comment #4 from Olivier Crete (Tester) <olivier.crete at ocrete.ca> 2013-06-10 22:34:30 UTC ---
Review of attachment 245806:
 --> (https://bugzilla.gnome.org/review?bug=701404&attachment=245806)

::: ext/dash/gstdashdemux.c
@@ +1571,3 @@
+
+  /* Prevent this thread from constantly running */
+  g_usleep (500000);

This is definitely wrong, you probably want to use a gst_clock_id_wait() until
the timeout expires, but be ready to be cancelled before in case of flush or of
the element being stopped.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list