[Bug 701509] dashdemux selects first fragment in the manifest for live streams

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=701509
  GStreamer | gst-plugins-bad | git

Olivier Crete (Tester) <olivier.crete> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #245912|none                        |needs-work
             status|                            |

--- Comment #2 from Olivier Crete (Tester) <olivier.crete at ocrete.ca> 2013-06-10 22:42:06 UTC ---
Review of attachment 245912:
 --> (https://bugzilla.gnome.org/review?bug=701509&attachment=245912)

::: ext/dash/gstdashdemux.c
@@ +235,3 @@
     GST_DEBUG_CATEGORY_INIT (gst_dash_demux_debug, "dashdemux", 0,
+        "dashdemux element");
+    );

Please don't mix re-ident changes into your patch.

::: ext/dash/gstmpdparser.c
@@ +1888,3 @@
         && Representation->SegmentList->MultSegBaseType->SegBaseType
+        && Representation->SegmentList->MultSegBaseType->SegBaseType->
+        Initialization) {

Spurious change..

@@ +3235,3 @@
+  g_assert (t1 != NULL && t2 != NULL);
+
+  /* TODO: Assumes difference is less than a day. */

You could use GDateTime here, it has a g_date_time_difference () function..

@@ +3421,3 @@
     *uri =
+        gst_mpdparser_get_initializationURL (stream->cur_segment_base->
+        Initialization);

Spurious change again

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.