[Bug 701421] opencv: add foreground/background segmentation element

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=701421
  GStreamer | gst-plugins-bad | 1.x

--- Comment #13 from Miguel (elmiguelao) Casas-Sanchez <miguelecasassanchez at gmail.com> 2013-06-11 12:00:57 UTC ---
(In reply to comment #12)
> Review of attachment 246400 [details]:
> 
> ::: ext/opencv/gstsegmentation.cpp
> @@ +295,3 @@
> +static gboolean
> +//gst_segmentation_set_caps (GstBaseTransform * btrans, GstCaps * incaps,
> +//    GstCaps * outcaps)
> 
> Don't use C99/C++ comments, also can just go away, no?

Yes, I just commented it out for a moment, when substituting set_caps with
set_info() function and they stood. Now removed.

> 
> @@ +303,3 @@
> +  GstVideoInfo info;
> +  CvSize size;
> +  gst_video_info_from_caps (&info, incaps);
> 
> You already get the info passed as parameter

True as well. Taken into.
> 
> @@ +375,3 @@
> +
> +  /*  get image data from the input, which is RGBA */
> +  filter->cvRGBA->imageData = (char *) GST_VIDEO_FRAME_COMP_DATA (frame, 0);
> 
> You might want to do something to handle the different possible strides here
> too... if OpenCV supports that.

Well it might well do, I'm not sure because I've never used openCV with
funky-aligned data. It relies on IplImage for that. I'm setting it now from the
video input frame:

  filter->cvRGBA->widthStep = (char *) GST_VIDEO_FRAME_COMP_PSTRIDE (frame, 0);

New patch coming.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.