[Bug 701404] dashdemux: should not buffer the entire Period

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=701404
  GStreamer | gst-plugins-bad | 1.x

Olivier Crete (Tester) <olivier.crete> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #246653|none                        |needs-work
             status|                            |

--- Comment #7 from Olivier Crete (Tester) <olivier.crete at ocrete.ca> 2013-06-12 16:27:23 UTC ---
Review of attachment 246653:
 --> (https://bugzilla.gnome.org/review?bug=701404&attachment=246653)

::: ext/dash/gstdashdemux.c
@@ +1567,2 @@
       } else {
+        goto quit;

This will never be reached, because you have:
if (cancelled) {} else if (!cancelled) {} else {...}

And doesn't quit just return, which means download_loop() will be called again
immediately? Are you missing some bit ?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.