[Bug 702112] waylandsink: add support for RGBx and RGBA formats

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=702112
  GStreamer | gst-plugins-bad | 1.x

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #246652|none                        |reviewed
             status|                            |

--- Comment #1 from Sebastian Dröge <slomo at circular-chaos.org> 2013-06-13 06:35:39 UTC ---
Review of attachment 246652:
 --> (https://bugzilla.gnome.org/review?bug=702112&attachment=246652)

::: ext/wayland/gstwaylandsink.c
@@ -64,3 @@
     GST_PAD_ALWAYS,
-    GST_STATIC_CAPS ("video/x-raw, "
-        "format = (string) BGRA, "

You mean BGRA is not supported anymore? Is this maybe endianness dependant?
BGRA on little endian, ARGB on big endian?

@@ +337,3 @@
+      break;
+    case GST_VIDEO_FORMAT_RGBA:
+      *wl_format = WL_SHM_FORMAT_ARGB8888;

This could be a implemented with a mapping table for easier future extension

@@ +367,3 @@
+  if (!(sink->display->formats & (1 << sink->format))) {
+    GST_DEBUG_OBJECT (sink, "%s not available",
+        (sink->format == WL_SHM_FORMAT_ARGB8888) ? "ARGB8888" : "XRGB8888");

Some kind of gst_wayland_format_to_string() might be useful here

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.