[Bug 702215] pbutils: descriptions: Allow smart codec tag handling

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=702215
  GStreamer | gst-plugins-base | unspecified

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #246780|none                        |reviewed
             status|                            |

--- Comment #2 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2013-06-14 09:10:24 UTC ---
(From update of attachment 246780)
That's a nice idea indeed. I only added these flags recently, that's why this
function is like it is. Maybe we should just add a new function that doesn't
take the tag argument? (_add_codec_to_tag_list?)

>+  /* Attempt to find tag classification */
>+  if (codec_tag == NULL) {
>+    /* Only use GST_TAG_{AUDIO|VIDEO|SUBTITLE}_CODEC for non-container formats */
>+    if (info->flags == FLAG_AUDIO)
>+      codec_tag = GST_TAG_AUDIO_CODEC;
>+    else if (info->flags == FLAG_VIDEO)
>+      codec_tag = GST_TAG_VIDEO_CODEC;
>+    else if (info->flags == FLAG_SUB)
>+      codec_tag = GST_TAG_SUBTITLE_CODEC;
>+    else
>+      codec_tag = GST_TAG_CODEC;
>+  }

I think this checking for non-container formats should be done differently
here, to be more future proof in case other flags are added. In particular, I
intend to add flags to signal whether formats are parsable/ES streams soon.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.