[Bug 702112] waylandsink: add support for RGBx and RGBA formats

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=702112
  GStreamer | gst-plugins-bad | 1.x

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #246740|none                        |needs-work
             status|                            |

--- Comment #5 from Sebastian Dröge <slomo at circular-chaos.org> 2013-06-14 12:37:19 UTC ---
Review of attachment 246740:
 --> (https://bugzilla.gnome.org/review?bug=702112&attachment=246740)

::: ext/wayland/gstwaylandsink.c
@@ +63,3 @@
     GST_PAD_SINK,
     GST_PAD_ALWAYS,
+    GST_STATIC_CAPS (GST_VIDEO_CAPS_MAKE ("{RGBx, RGBA}"))

Are you sure this is correct? It seems to be BGRA/BGRx on little-endian system
as I understand it... and ARGB/xRGB on big endian systems.

@@ +102,3 @@
+} wl_VideoFormat;
+
+static wl_VideoFormat formats[] = {

This should be const

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.