[Bug 702330] mpegvideoparse: Only map input buffer once

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=702330
  GStreamer | gst-plugins-bad | unspecified

--- Comment #2 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2013-06-17 10:47:23 UTC ---
(From update of attachment 246885)
Hah, nice.

> static gboolean
>-gst_mpegv_parse_process_config (GstMpegvParse * mpvparse, GstBuffer * buf,
>+gst_mpegv_parse_process_config (GstMpegvParse * mpvparse, GstMapInfo * info,
>     guint size)
> {

Minor nitpick: size is now also in info.size, isn't it (if you always pass
gst_buffer_get_size() anyway), so doesn't have to be passed separately if info
is passed?

Also, I wonder if it wouldn't be even better to pass info.data instead of the
whole GstMapInfo *? Then the compiler doesn't have to re-read info>data
everytime it's accessed.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.