[Bug 702826] gdkpixbufoverlay: image overlay doesn't work for -ve offset

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=702826
  GStreamer | gst-plugins-good | 1.0.7

Nicolas Dufresne <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #247464|none                        |needs-work
             status|                            |

--- Comment #1 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2013-06-21 16:45:16 UTC ---
Review of attachment 247464:
 --> (https://bugzilla.gnome.org/review?bug=702826&attachment=247464)

This seems more correct, I'd need to look at more context, meawhile there is
some small fixes required.

::: ext/gdk_pixbuf/gstgdkpixbufoverlay.c
@@ +141,3 @@
+          "For +ve value, horizontal offset of overlay image in pixels from"
+          " left of video image. For -ve value, horizontal offset of overlay"
+          " image in pixels from right of video image", G_MININT, G_MAXINT, 0,

Might be me, but I see no difference in those two, ve is not very common
acronym I think.

@@ +459,3 @@
+    video_height+overlay->offset_y - overlay_meta->height +
+    (overlay->relative_y * overlay_meta->height) :
+    overlay->offset_y + (overlay->relative_y * overlay_meta->height);

Coding style require that operators (-+) have spaces before and after. It's
quite clear though that the original code would not work with negative values.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.