[Bug 702837] dashdemux: Cleanup use of xmlFree vs g_free

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon Jun 24 18:03:47 PDT 2013


http://bugzilla.gnome.org/show_bug.cgi?id=702837
  GStreamer | gst-plugins-bad | 1.x

Thiago Sousa Santos <thiago.sousa.santos> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #247536|none                        |needs-work
             status|                            |

--- Comment #2 from Thiago Sousa Santos <thiago.sousa.santos at collabora.co.uk> 2013-06-25 01:03:42 UTC ---
Review of attachment 247536:
 --> (http://bugzilla.gnome.org/review?bug=702837&attachment=247536)

While the bug exists, this patch needs more work. Some of the variables that
were switched to being freed by xmlFree were actually created using a g_strdup
and should remain being freed with g_free.

Also there is nothing in the xmlFree docs that says how it handles NULL values,
while g_free handles it. So switching to xmlFree might also required an
"if(variable) xmlFree(variable)"

-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list