[Bug 702206] dashdemux: media range requests not supported

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=702206
  GStreamer | gst-plugins-bad | 1.x

--- Comment #19 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2013-06-26 19:20:59 UTC ---
Review of attachment 247785:
 --> (http://bugzilla.gnome.org/review?bug=702206&attachment=247785)

::: ext/soup/gstsouphttpsrc.c
@@ +533,3 @@
+   * async handlers might set src->msg to NULL, so we keep the pointer */
+  msg = src->msg;
+  soup_session_send_message (src->session, src->msg);

How is this unblocked when you receive a flush or going to NULL state ? I'm
under the impression that simply doing g_main_loop_quit() may leak some data
with this method, what do you think ?

@@ +674,3 @@
+    g_main_context_unref (src->context);
+    return FALSE;
+  }

g_main_loop_new() never fails, but I think you just moved that code over.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.