[Bug 703350] qtdemux reports wrong framerate

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=703350
  GStreamer | gst-plugins-good | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #248087|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge <slomo at circular-chaos.org> 2013-06-30 17:13:36 UTC ---
Review of attachment 248087:
 --> (https://bugzilla.gnome.org/review?bug=703350&attachment=248087)

::: gst/isomp4/qtdemux.c
@@ +5464,3 @@
+      /* we might need to scale the timescale to get precise framerate */
+      const int required_scale = log10 (10000);
+      int current_scale = log10 (stream->timescale);

You need to link with $(LIBM) for this, and also log10() is not available
everywhere. Only log() is safe to use.

@@ +5474,3 @@
+        stream->fps_d =
+            floor ((double) (stream->duration * factor) /
+            (double) stream->n_samples + 0.5);

gst_util_uint64_scale_int_round() maybe?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.