[Bug 698927] LADSPA improved port to gstreamer 1.0

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=698927
  GStreamer | gst-plugins-bad | git

Stefan Sauer (gstreamer, gtkdoc dev) <ensonic> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #242525|none                        |reviewed
             status|                            |

--- Comment #9 from Stefan Sauer (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2013-05-02 06:41:46 UTC ---
Review of attachment 242525:
 --> (https://bugzilla.gnome.org/review?bug=698927&attachment=242525)

Okay, lets keep the "src", "sink" names.

::: ext/ladspa/gstladspautils.c
@@ +26,3 @@
+ *
+ * FIXME:
+ * Assigning channel orders could be tricky since LADSPA seems to not

LADSPA has no channel order. All we could do is to parse the port names for
"(Left)/(Right)", "-L/-R" or ":l/:r" - these are the 3 patterns I see most of
the time.

@@ +28,3 @@
+ * Assigning channel orders could be tricky since LADSPA seems to not
+ * specify order of channels in a really nice computer parseable way,
+ * stereo is probably wrong, more than stereo is crazy. By now, it justs

typo: s/justs/just

@@ +32,3 @@
+ * channel-masks and/or channel positions correctly, if this is needed
+ * and expected, users will tell (this affects mainly interleaving).
+ *

I think, you could mention, that right now, you just interleave all input port
and output ports. This is the right thing in 90% of the cases, but will e.g.
create a 4 channel out for a plugin that has 2 stereo 'pairs'.

@@ +47,3 @@
+#define GST_CAT_DEFAULT ladspa_debug
+
+/* 

FYI: GStreamer-1.0 also supports not-interleaved audio, where you just memcpy
each channel after each other: c1...c1c2....c2 and so on.

--- Comment #10 from Stefan Sauer (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2013-05-02 06:42:03 UTC ---
Review of attachment 242525:
 --> (https://bugzilla.gnome.org/review?bug=698927&attachment=242525)

Okay, lets keep the "src", "sink" names.

::: ext/ladspa/gstladspautils.c
@@ +26,3 @@
+ *
+ * FIXME:
+ * Assigning channel orders could be tricky since LADSPA seems to not

LADSPA has no channel order. All we could do is to parse the port names for
"(Left)/(Right)", "-L/-R" or ":l/:r" - these are the 3 patterns I see most of
the time.

@@ +28,3 @@
+ * Assigning channel orders could be tricky since LADSPA seems to not
+ * specify order of channels in a really nice computer parseable way,
+ * stereo is probably wrong, more than stereo is crazy. By now, it justs

typo: s/justs/just

@@ +32,3 @@
+ * channel-masks and/or channel positions correctly, if this is needed
+ * and expected, users will tell (this affects mainly interleaving).
+ *

I think, you could mention, that right now, you just interleave all input port
and output ports. This is the right thing in 90% of the cases, but will e.g.
create a 4 channel out for a plugin that has 2 stereo 'pairs'.

@@ +47,3 @@
+#define GST_CAT_DEFAULT ladspa_debug
+
+/* 

FYI: GStreamer-1.0 also supports not-interleaved audio, where you just memcpy
each channel after each other: c1...c1c2....c2 and so on.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.