[Bug 699302] h264parse doesn't wait for complete output caps, leading to not-negotiated errors when remuxing

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon May 6 09:00:20 PDT 2013


https://bugzilla.gnome.org/show_bug.cgi?id=699302
  GStreamer | gst-plugins-bad | git

--- Comment #5 from Ilya Smelykh <ilya.smelykh at gmail.com> 2013-05-06 16:00:14 UTC ---
(From update of attachment 243395)
>diff --git a/gst/videoparsers/gsth264parse.c b/gst/videoparsers/gsth264parse.c
>index 6da80f2..5b4a50a 100644
>--- a/gst/videoparsers/gsth264parse.c
>+++ b/gst/videoparsers/gsth264parse.c
>@@ -882,7 +882,16 @@ gst_h264_parse_handle_frame (GstBaseParse * parse,
>       }
>     }
> 
>-    gst_h264_parse_process_nal (h264parse, &nalu);
>+    if ((!h264parse->have_sps && nalu.type == GST_H264_NAL_SPS) ||
>+        (!h264parse->have_pps && nalu.type == GST_H264_NAL_PPS) ||
>+        (h264parse->have_sps && h264parse->have_sps)) {
>+      gst_h264_parse_process_nal (h264parse, &nalu);
>+    }
>+    else {
>+      GST_WARNING_OBJECT (h264parse, "no SPS/PPS yet, nal Type: %d, Size: %u will be dropped", nalu.type, nalu.size);
>+      *skipsize = nalu.size;
>+      goto skip;
>+    }
> 
>     if (nonext)
>       break;

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list