[Bug 699792] Oggmux ends up choosing an eos pad as the best pad.

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=699792
  GStreamer | gst-plugins-base | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |slomo at circular-chaos.org

--- Comment #3 from Sebastian Dröge <slomo at circular-chaos.org> 2013-05-07 07:14:35 UTC ---
Wouldn't this cause NULL to be returned from that function if all pads are EOS,
and then this code in _collected() happens:
>  if (best == NULL || best->buffer == NULL) {
>    /* This is not supposed to happen */
>    return GST_FLOW_ERROR;
>  }

gst_ogg_mux_queue_pads() should probably return any of the pads if all of them
are EOS, and in _collected() there should be a check for EOS and no buffer
before the lines I quoted above.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.