[Bug 699786] mpegtsmux: memory leak when using prepare_func

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=699786
  GStreamer | gst-plugins-bad | 1.x

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #243438|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge <slomo at circular-chaos.org> 2013-05-07 07:26:15 UTC ---
Review of attachment 243438:
 --> (https://bugzilla.gnome.org/review?bug=699786&attachment=243438)

::: gst/mpegtsmux/mpegtsmux.c
@@ +1023,2 @@
       gst_buffer_replace (outbuf, buf);
+      gst_buffer_unref (buf);

Shouldn't this be something like this?
*outbuf = pad_data->prepare_func (...);
gst_buffer_unref (buf);

The prepare_func creates a new buffer that is returned but the original buf is
never unreffed.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.