[Bug 698712] playbin: autoplug video decoder and sink based on caps features

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=698712
  GStreamer | gst-plugins-base | git

--- Comment #78 from sreerenj <bsreerenj at gmail.com> 2013-05-07 09:21:13 UTC ---
(In reply to comment #77)
> Review of attachment 243011 [details]:
> 
> No, you're not doing that in your patch :)
> 
> ::: gst/playback/gstplaybin2.c
> @@ +3449,3 @@
>        ave->sink = gst_object_ref (s_factory);
>        ave->n_comm_cf = n_common_cf;
> +      g_sequence_append (ave_seq, ave);
> 
> This should use g_sequence_insert_sorted() and the compare function should only
> compare the factories (by pointer). 


You mean to compare based on rank and name ??? otherwise how to insert in to
correct position? 

Due to the way how GSequence is implemented
> this has no overhead over "append and sort in the end".
> 
> @@ +3453,3 @@
>      sl = sink_list;
>    }
> +  g_sequence_sort (ave_seq, (GCompareDataFunc) avelement_compare, NULL);
> 
> This is not necessary anymore then
> 
> @@ +3486,3 @@
>    }
> 

GSequence ref manual is preferring to use g_sequence_sort instead of
insert_sort if the list is big.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.