[Bug 699302] h264parse doesn't wait for complete output caps, leading to not-negotiated errors when remuxing

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=699302
  GStreamer | gst-plugins-bad | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #243395|none                        |needs-work
             status|                            |

--- Comment #7 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2013-05-07 11:36:02 UTC ---
(From update of attachment 243395)
>diff --git a/gst/videoparsers/gsth264parse.c b/gst/videoparsers/gsth264parse.c
>index 6da80f2..5b4a50a 100644
>--- a/gst/videoparsers/gsth264parse.c
>+++ b/gst/videoparsers/gsth264parse.c
>@@ -882,7 +882,16 @@ gst_h264_parse_handle_frame (GstBaseParse * parse,
>       }
>     }
> 
>-    gst_h264_parse_process_nal (h264parse, &nalu);
>+    if ((!h264parse->have_sps && nalu.type == GST_H264_NAL_SPS) ||
>+        (!h264parse->have_sps && nalu.type == GST_H264_NAL_PPS) ||
>+        (h264parse->have_sps && h264parse->have_sps)) {
>+      gst_h264_parse_process_nal (h264parse, &nalu);
>+    }

I think there are some have_sps/pps mixups here?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.