[Bug 699302] h264parse doesn't wait for complete output caps, leading to not-negotiated errors when remuxing

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=699302
  GStreamer | gst-plugins-bad | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #243487|none                        |reviewed
             status|                            |

--- Comment #10 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2013-05-07 15:24:51 UTC ---
(From update of attachment 243487)

>-    gst_h264_parse_process_nal (h264parse, &nalu);
>+    if ((!h264parse->have_sps && nalu.type == GST_H264_NAL_SPS) ||
>+        (!h264parse->have_pps && nalu.type == GST_H264_NAL_PPS) ||
>+        (h264parse->have_sps && h264parse->have_pps)) {
>+      gst_h264_parse_process_nal (h264parse, &nalu);
>+    }

Apologies for the nitpicking, but shouldn't it be:

if (nalu.type == SPS || nalu.type == PPS ||
   (have_sps && have_pps)) {
  .. process_nal();
}

(there can be multiple PPS, no? And we want to update the SPS even if we
already have one (irrespective of whether we have an PPS or not))

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.