[Bug 699972] videodecoder: Output segment can be undefined before a call to gst_segment_clip

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=699972
  GStreamer | gst-plugins-base | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #243658|none                        |rejected
             status|                            |

--- Comment #2 from Sebastian Dröge <slomo at circular-chaos.org> 2013-05-09 14:15:33 UTC ---
Review of attachment 243658:
 --> (https://bugzilla.gnome.org/review?bug=699972&attachment=243658)

This is not correct, you should set the output segment only from the output
side of things, not the input side.

Also receiving a new segment event will not reset the segments, only when
gst_video_decoder_flush() is called with TRUE it will do that. Or am I missing
something here? How can it be reproduced?

::: gst-libs/gst/video/gstvideodecoder.c
@@ +2000,2 @@
         g_list_prepend (decoder->priv->current_frame_events, event);
   }

Right above this here the input segment is initialized and a segment event is
enqueued. This will cause the output segment to be set later when a frame is
finished.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.