[Bug 700222] rtpbasepayload: Need to delay segments event after caps event

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon May 13 16:16:33 PDT 2013


https://bugzilla.gnome.org/show_bug.cgi?id=700222
  GStreamer | gst-plugins-base | git

--- Comment #9 from Olivier Crete (Tester) <olivier.crete at ocrete.ca> 2013-05-13 23:16:27 UTC ---
Review of attachment 244121:
 --> (https://bugzilla.gnome.org/review?bug=700222&attachment=244121)

I must say I'm not happy having to force the order like that everywhere.. I
still feel like the core should be doing this.

::: gst-libs/gst/rtp/gstrtpbasepayload.c
@@ +921,3 @@

+  if (G_LIKELY (res == GST_FLOW_OK)) {
+    if (payload->priv->pending_segment) {

might want a G_UNLIKELY() here

@@ +954,3 @@

+  if (G_LIKELY (res == GST_FLOW_OK)) {
+    if (payload->priv->pending_segment) {

and here too

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list