[Bug 697806] avdec_h264 Fails during error recovery after packet loss leading to stream corruption

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=697806
  GStreamer | gst-libav | 1.0.5

--- Comment #13 from tcdgreenwood at hotmail.com 2013-05-14 14:42:46 UTC ---
Latest master looks good apart from bad isn't building.  I have run this and it
looks like this is caused by the change in libav version.  It seems (still
investigating) that the new libav copies the opaque value between copies of the
same frame meaning I loose the association between the buffer object allocated
by gstreamer and the buffer used by libav.  I think I could fix it by ignoring
the opaque already being set, but I am a little nervous that it could mean some
error conditions not being detected and even possibly leaking buffers.

I think that I will fix this by moving to get_buffer2, as this allows an opaque
to be stored against each buffer which is what I was really trying to do with
this patch and I am confident that longer term it's the right move. 
Unfortunately moving to use get_buffer2 will take a little bit of time
(especially with testing).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.