[Bug 700411] [dmabuf allocator]: optimize map/unmap call

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=700411
  GStreamer | gst-plugins-base | 1.x

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #244397|none                        |needs-work
             status|                            |

--- Comment #7 from Sebastian Dröge <slomo at circular-chaos.org> 2013-05-17 06:38:22 UTC ---
Review of attachment 244397:
 --> (https://bugzilla.gnome.org/review?bug=700411&attachment=244397)

::: gst-libs/gst/allocators/gstdmabuf.c
@@ +69,2 @@
+  if (mem->data) {
+    g_warning("Freeing memory still mapped");

Best would be to add some information here about here this happens, e.g.
g_warning (G_STRLOC ":%s: Freeing memory %p still mapped", G_STRFUNC, mem)

@@ +115,3 @@
     mem->mmap_size = maxsize;
     mem->mmap_count++;
+    gmem->size = maxsize;

This should already be fixed by

commit ced858fa657abe7422e0d5da3a7247570fef7605
Author: Michael Olbrich <m.olbrich at pengutronix.de>
Date:   Thu May 16 09:07:46 2013 +0200

    dmabuf: set the initial memory size to the full size

    https://bugzilla.gnome.org/show_bug.cgi?id=700427

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.