[Bug 700600] videomixer: Fix races in caps negotiation and re enable the unit test

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Sat May 18 12:51:53 PDT 2013


https://bugzilla.gnome.org/show_bug.cgi?id=700600
  GStreamer | gst-plugins-good | 1.x

--- Comment #2 from Thibault Saunier <thibault.saunier at collabora.com> 2013-05-18 19:51:49 UTC ---
Created an attachment (id=244654)
 View: https://bugzilla.gnome.org/attachment.cgi?id=244654
 Review: https://bugzilla.gnome.org/review?bug=700600&attachment=244654

videomixer: Do not send flush_stop when receiving a seek

There is no reason to send a flush-stop when receiving a seek event.
In the case of a flushing seek, we could eventually want to, but in
the code path were we check if the seek is "flushing", we have the
following comment that makes sense:

"we can't send FLUSH_STOP here since upstream could start pushing data
after we unlock mix->collect.
We set flush_stop_pending to TRUE instead and send FLUSH_STOP after
forwarding the seek upstream or from gst_videomixer_collected,
whichever happens first."

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list