[Bug 684237] videomixer: Caps negotiation does not always work

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=684237
  GStreamer | gst-plugins-good | git

Nicolas Dufresne <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #244688|none                        |accepted-commit_now
             status|                            |

--- Comment #49 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2013-05-19 01:17:08 UTC ---
Review of attachment 244688:
 --> (https://bugzilla.gnome.org/review?bug=684237&attachment=244688)

This seems like a good idea, and it compensate the fact the caps event is being
handled in two sequences of lock/unlock, though this should eventually be
fixed.

::: gst/videomixer/videomixer2.c
@@ +2071,3 @@
   mix->collect = gst_collect_pads_new ();
   mix->background = DEFAULT_BACKGROUND;
+  mix->current_caps = NULL;

This is optional, gobject are initialize to zero at allocation. Not a blocker
to me.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.