[Bug 684237] videomixer: Caps negotiation does not always work

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=684237
  GStreamer | gst-plugins-good | git

--- Comment #58 from Sebastian Dröge <slomo at circular-chaos.org> 2013-05-20 16:00:33 UTC ---
(In reply to comment #57)
> (In reply to comment #53)
> > (From update of attachment 229286 [details] [details])
> > I don't think this patch is correct, video caps should always contain those
> > fields... and additional fields will not cause accept-caps to fail.
> 
> Here's an example:
> 
> -> Branch A choose video/x-raw, but videomixer sets
> video/x-raw,pixel-aspect-ratio=1/1
> -> Branch B choose video/x-raw, which will fail accept caps, since video/x-raw
> is not a bubset of video/x-raw,pixel...
> 
> Using gst_video_info_(from/to)_caps() is what introduce this issue.

Where would the caps without pixel-aspect-ratio come from? I think we should
hardcode the list of omitted fields though, or better, only put a fixed list of
fields into the srcpad caps (everything that must not change and everything
that must be provided, i.e. format, pixel-aspect-ratio, ... and width/height).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.