[Bug 700654] opencv skin colour detection plugin

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=700654
  GStreamer | gst-plugins-bad | 1.x

--- Comment #3 from Miguel (elmiguelao) Casas-Sanchez <miguelecasassanchez at gmail.com> 2013-05-20 20:07:19 UTC ---
(In reply to comment #2)
> Review of attachment 244730 [details]:
> 
> Why isn't this based on GstVideoFilter or at least GstBaseTransform? Same goes
> for many other of the OpenCV elements...
> 
I made it based on GstOpencvVideoFilter, which in turn is based on
GstVideoFilter. Before, I started with a copy of edgedetect, which was not
based on any VideoFilter, hence my mistake.

> ::: ext/opencv/gstskindetect.c
> @@ +157,3 @@
> +          (G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS)));
> +  g_object_class_install_property (gobject_class, PROP_ENABLE,
> +      g_param_spec_boolean ("enable", "Enable",
> 
> For the other OpenCV filters there is no such property

Originally it was there to solve large pipeline caps negotiation problems, but
I removed it indeed.
> 
> @@ +162,3 @@
> +          (G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS)));
> +  g_object_class_install_property (gobject_class, PROP_METHOD,
> +      g_param_spec_int ("method",
> 
> Please use a GEnum type here and g_param_spec_enum()
> 
Not really needed, I put them as #define's.

> @@ +305,3 @@
> +
> +  buf = gst_buffer_make_writable (buf);
> +  gst_buffer_map (buf, &in_info, GST_MAP_WRITE);
> 
> Should be GST_MAP_READ as this is only read, not written to.
> 
> @@ +318,3 @@
> +    }
> +  }
> + 
> //////////////////////////////////////////////////////////////////////////////
> 
> Please use C comments (/* blabla */)

Done.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.