[Bug 700748] rtpjpegpay/depay: Add framerate and optional framesize SDP attribute to payloaded caps

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=700748
  GStreamer | gst-plugins-good | git

--- Comment #15 from Sebastian Rasmussen <sebras at hotmail.com> 2013-05-22 14:05:45 UTC ---
Ok, so the details were hashed out on #gstreamer instead of in bugzilla, quoted
here should anyone try to figure out why the code looks like this at some
point.

12:01 < sebras> slomo: when I spoke with wtay the other day I read him as that
it was ok to always set the framesize SDP attribute. this is why I see
width/height as required.
12:02 < slomo> sure, it's always ok to *generate* that
12:02 < slomo> but can we always require to *get* that from anything that
generates rtp streams?
12:02 < slomo> from what you say i don't think so
12:02 < slomo> so it should be optional in the depayloader, but mandatory in
the payloader
12:02 < sebras> slomo: ok. so then there shouldn't even be width/height on the
srcpad of the depayloader...?
12:03 < sebras> slomo: however if we happen to get those width/height caps then
we might propagate them.
12:03 < slomo> yes, the depayloader shouldn't have that in the template caps
(on both pads). just add it on srcpad caps if the input contains it
12:04 < sebras> slomo: ok. back to the drawing board. thanks for hashing this
out. :)
12:04 < slomo> sebras: that's the same behaviour you have for the framerate,
right?
12:06 < sebras> slomo: mostly. framerate is not required even in the payloader
as it might not be present in caps (not required for parsed jpeg/h264).
12:08 < slomo> sebras: and in the depayloader it's optional too (i.e. not in
the template caps, but used when present)?
12:08 < sebras> slomo: yes, exactly.
12:09 < sebras> slomo: and in gst-rtsp-server the a=framerate SDP attribute is
generated if the framerate caps is present.
12:10 < slomo> ok
12:10 < slomo> so just do the same for the width/height in the depayloader ;)
but in the payloader it should be mandatory (so in both template caps)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.