[Bug 700868] videomixer: Multiple locking error

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=700868
  GStreamer | gst-plugins-good | git

--- Comment #8 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2013-05-23 13:45:47 UTC ---
(In reply to comment #4)
> Created an attachment (id=245096)
 View: https://bugzilla.gnome.org/attachment.cgi?id=245096
 Review: https://bugzilla.gnome.org/review?bug=700868&attachment=245096

> videomixer: Release COLLECT_PAD_STREAM lock when sending eos
> 
> It create deadlock in case we get a flush_stop while we are sending it.

That is strange, a flush-start event should have had unblocked that. Is it an
eos sent in gnlcomposition from eos_main_thread() ?  This could explain,
gnlcomp get an EOS, instead of checking if it's the end and forward it, it fire
the g_idle_add, and figure-out if it's the end from there, which is racy. Other
possibility is that the pipeline was not linked completly when flush-start was
sent, but I don't think this patch is correct.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.