[Bug 700903] New: Possible memory leak in tsdemux

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=700903
  GStreamer | gst-plugins-bad | 1.0.7

           Summary: Possible memory leak in tsdemux
    Classification: Platform
           Product: GStreamer
           Version: 1.0.7
        OS/Version: Windows
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: mrubinstein at weather.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


In the function mpegts_get_descriptor_from_stream() in:
 gst-plugins-bad\gst\mpegtsdemux\mpegtsbase.c 
is the following code:

  for (i = 0; i < descriptors->n_values; i++) {
    GValue *value = g_value_array_get_nth (descriptors, i);
    GString *desc = g_value_dup_boxed (value);
    if (DESC_TAG (desc->str) == tag) {
      retval = (guint8 *) desc->str;
      g_string_free (desc, FALSE);
      break;
    } else
      g_string_free (desc, FALSE);      // <<< should be TRUE?
  }

If we find the matching tag, we want to keep desc->str, but free desc.
If we don't match, we want to delete both, I think.

Changing to "TRUE" fixed a memory leak for me.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.