[Bug 698851] playbin: ability to mix or play multiple audio and text streams simultaneously

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=698851
  GStreamer | gst-plugins-base | git

--- Comment #18 from Brendan Long <self at brendanlong.com> 2013-05-23 16:43:39 UTC ---
(In reply to comment #17)
> Instead of this I would add checks for all of the (relevant) input-selector
> properties... and if the custom selectors allows one of them, allow to use it
> through playbin.

Isn't that what I'm doing? Do you just want all of the checks up-front, instead
of as-needed?

> Handle this exactly like the sinks, i.e. basically copy the set_sink() function
> and also include the behaviour from playsink for the sinks.

That's fixed.

> Store them in the GstSourceGroup and GstSourceSelect at the same place where
> otherwise the input-selector would be created,

Already done, except I also store them in playbin->*_stream_combiner, similar
to playbin->*_sink. They're reffed and added to the group in activate_group
(just like the sinks).

> and add/remove them from the bin
> at the same time as the input-selector would currently be added/removed.

Should playbin be doing this? The sinks are just expected to be in the bin
(gst_bin_add and gst_bin_remove are never called on them). It does seem more
user-friendly to do that automatically, but it will also be inconsistent.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.