[Bug 698851] playbin: ability to mix or play multiple audio and text streams simultaneously

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=698851
  GStreamer | gst-plugins-base | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #245279|none                        |needs-work
             status|                            |

--- Comment #25 from Sebastian Dröge <slomo at circular-chaos.org> 2013-05-25 13:45:23 UTC ---
Review of attachment 245279:
 --> (https://bugzilla.gnome.org/review?bug=698851&attachment=245279)

Looks good, just one minor comment below :)

Are you aware of any remaining issues? I can't see any.

Could you create a unit test for this new API, see
tests/check/elements/playbin.c. Shouldn't be too difficult to add something
there that just uses adder for multiple audio streams

::: gst/playback/gstplaybin2.c
@@ +3002,3 @@
+          g_object_class_find_property (G_OBJECT_GET_CLASS (select->selector),
+          "sync-mode") != NULL;
+      select->has_sync_streams =

cache-buffers, sync-mode and sync-streams are very input-selector specific. I
just only use them if input-selector is used

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.