[Bug 700977] opencv: add colour image enhancement element based on Retinex algorithm

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=700977
  GStreamer | gst-plugins-bad | 1.x

--- Comment #6 from Miguel (elmiguelao) Casas-Sanchez <miguelecasassanchez at gmail.com> 2013-05-26 18:39:21 UTC ---
(In reply to comment #5)
> (In reply to comment #2)
> > New patch coming.
> > 
> > (In reply to comment #1)
> > > Review of attachment 245277 [details] [details] [details]:
> > > 
> > > ::: ext/opencv/gstretinex.c
> > > @@ +104,3 @@
> > > +}
> > > +
> > > +G_DEFINE_TYPE (GstRetinex, gst_retinex, GST_TYPE_VIDEO_FILTER);
> > > 
> > > Why plain GstVideoFilter and not GstOpenCvVideoFilter?
> > I have developed this in the (near) past and used VideoFilter. Should I change
> > it?
> 
> I don't know, I assume GstOpenCvVideoFilter already handles some OpenCv related
> things for you and thus makes your life easier and the code shorter :) Does it?

Mmm perhaps but I'm not fully familiar with that "class", f.i. in line 210,
transform_ip, the input buffer is mapped and the return of the function is not
checked. That said, in my previous patch for skin detection I used it :) In
other words, you're more experienced than me with Gstreamer so I'll take your
recommendation.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.