[Bug 701095] videomixer: Should implement pass-through and optimizations

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=701095
  GStreamer | gst-plugins-good | 1.x

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #245426|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge <slomo at circular-chaos.org> 2013-05-28 07:57:48 UTC ---
Review of attachment 245426:
 --> (https://bugzilla.gnome.org/review?bug=701095&attachment=245426)

::: gst/videomixer/videomixer2.c
@@ +831,3 @@
+    if (top_pad->alpha == 1.0 && (top_pad->xpos + top_pad->ypos == 0)
+        && mix->info.width == top_pad->info.width
+        && mix->info.height == top_pad->info.height) {

This is not catching all cases. You could have a top pad that is larger than
fullscreen, which could have negative x/y-pos and still fill the complete
frame. Or could have negative x/y-pos and not fill the complete frame.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.