[Bug 701237] New: videomixer : on query caps, we should return FALSE if the source pad has no current caps.

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=701237
  GStreamer | gst-plugins-good | git

           Summary: videomixer : on query caps, we should return FALSE if
                    the source pad has no current caps.
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: mathieu.duponchelle at epitech.eu
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=245607)
 View: https://bugzilla.gnome.org/attachment.cgi?id=245607
 Review: https://bugzilla.gnome.org/review?bug=701237&attachment=245607

Proposed patch to fix the issue

For now, I have a case where

1) the caps get queried
2) get_current_caps(srcpad) returns NULL
3) make_writable is called on NULL, which causes a miniobject != NULL
assertion.

I have not investigated the cause of the caps being NULL in that specific case,
but it seems quite logical to me to return FALSE to the query instead of
raising that assertion, and the case I'm implementing now (videomixing in
GESVideoTracks) (kind of) works, at least I don't experience any caps / caps
negotiation issues.

The proposed patch does exactly that.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.